Add support for limit in update and delete queries for MySQL driver #140
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cf35cfb to
5c78161
Compare
Contributor
Author
|
ping @dg |
src/Database/Table/SqlBuilder.php
Outdated
| $query = "UPDATE {$this->delimitedTable} SET ?set" . $this->tryDelimite($this->buildConditions()); | ||
| if ($this->limit !== NULL || $this->offset) { | ||
| throw new Nette\NotSupportedException('LIMIT clause is not supported in UPDATE query.'); | ||
| if($this->driver->isSupported(ISupplementalDriver::SUPPORT_UPDATE_LIMIT)) { |
Contributor
Author
|
Missing space after 'if' added and squashed into single commit. |
Member
|
Thanks! |
Member
|
Now I think about it: what about apply limit & offset always, without checking of SUPPORT_UPDATE_LIMIT? If it will not be supported by database, it throws exception, right? |
Contributor
Author
|
I've searched for LIMIT clause support in databases supported by Nette\Database and only Sqlite has compile switch to enable/disable limit in update/delete. So remove check and leave it on database driver to throw exception seems as better solution. I'll update commit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I've prepared this pull request as solution for issue #120. It add support for limit in update and delete queries in MySQL as desribed in documentation http://dev.mysql.com/doc/refman/5.7/en/update.html + http://dev.mysql.com/doc/refman/5.7/en/delete.html.
It add new constants to ISupplementalDriver SUPPORT_UPDATE_LIMIT and SUPPORT_DELETE_LIMIT so each driver can define support. If it's not supported, then is throw same exception as before.