Skip to content

BC break in patch version: Component::link() signature #298

@xificurk

Description

@xificurk

Version: 3.1.4

Bug Description

Version 3.1.4 changed the signature of Component::link() (use variadic parameter). This is a BC break affecting anyone overriding the method or using any library that does so (e.g. nextras/secured-links).

Steps To Reproduce

Upgrade nette/application to v3.1.4 in any project using nextras/secured-links and try to run the app.

Expected Behavior

App runs :)

Actual Behavior

Fatal error: Declaration of Nextras\Application\UI\SecuredLinksControlTrait::link(string $destination, $args = []): string must be compatible with Nette\Application\UI\Component::link(string $destination, ...$args): string

Possible Solution

Revert the method signature change.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions