Skip to content

Possible fix for Exception handling#61

Merged
UrielCh merged 2 commits intonetplex:masterfrom
GanbaruTobi:master
Apr 1, 2021
Merged

Possible fix for Exception handling#61
UrielCh merged 2 commits intonetplex:masterfrom
GanbaruTobi:master

Conversation

@GanbaruTobi
Copy link
Copy Markdown

Possible fix for #60

@pronovic
Copy link
Copy Markdown

Note that this potential fix is tied to CVE-2021-27568, categorized as base score 9.1 (critical).

@asheppard-work
Copy link
Copy Markdown

Can this be merged?

@rajrajarathinam
Copy link
Copy Markdown

Please let us know ,when will be the next version available with the fix

@vkolomeyko
Copy link
Copy Markdown

Probably would be a good idea to also modify: https://github.com/netplex/json-smart-v2/blob/master/json-smart/src/test/java/net/minidev/json/test/TestFloat.java to expose the problem and then prove that the fix has desired effect.

@vkolomeyko
Copy link
Copy Markdown

@UrielCh - do you know if there any plans to release new version of the library? (2.3 was released back in 2017)

@UrielCh
Copy link
Copy Markdown
Contributor

UrielCh commented Apr 1, 2021

soo, I finally need to release.

let's setup java 😅

@UrielCh
Copy link
Copy Markdown
Contributor

UrielCh commented Apr 1, 2021

can you give me some value that failed ?

@UrielCh
Copy link
Copy Markdown
Contributor

UrielCh commented Apr 1, 2021

"-."
"2e+"
"[45e-"
"0.12345678912345678"

@UrielCh UrielCh merged commit 5504116 into netplex:master Apr 1, 2021
@UrielCh
Copy link
Copy Markdown
Contributor

UrielCh commented Apr 1, 2021

JUnit test are missing, let add somes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants