Skip to content

Remove the inlined ASM dependency in smart-accessors#35

Merged
UrielCh merged 1 commit intonetplex:v2.3from
mattnelson:master
Nov 3, 2016
Merged

Remove the inlined ASM dependency in smart-accessors#35
UrielCh merged 1 commit intonetplex:v2.3from
mattnelson:master

Conversation

@mattnelson
Copy link
Copy Markdown
Contributor

@mattnelson mattnelson commented Oct 21, 2016 •
edited
Loading

Addresses #20

Example output when shading asm and accessors-smart into the same assembly. After the changes were applied the overlapping classes error was resolved.

asm-5.1.jar, accessors-smart-1.1.jar define 25 overlapping classes:
  - org.objectweb.asm.Type
  - org.objectweb.asm.AnnotationVisitor
  - org.objectweb.asm.MethodVisitor
  - org.objectweb.asm.Attribute
  - org.objectweb.asm.MethodWriter
  - org.objectweb.asm.Handler
  - org.objectweb.asm.ByteVector
  - org.objectweb.asm.Opcodes
  - org.objectweb.asm.signature.SignatureReader
  - org.objectweb.asm.FieldVisitor
  - 15 more...

@mattnelson mattnelson mentioned this pull request Oct 21, 2016
Closed
@UrielCh UrielCh changed the base branch from master to v2.3 November 3, 2016 15:45
@UrielCh UrielCh merged commit d4844f2 into netplex:v2.3 Nov 3, 2016
@mattnelson
Copy link
Copy Markdown
Contributor Author

mattnelson commented Nov 3, 2016

@UrielCh Do you have a timeline of when we can expect this to be released?

@burtonator
Copy link
Copy Markdown

burtonator commented Dec 1, 2016

Please merge this and I will be every so happy!!!

@cowst
Copy link
Copy Markdown

cowst commented Dec 29, 2016

Waiting for this as well.

@burtonator
Copy link
Copy Markdown

burtonator commented Dec 29, 2016

I think it would be fair to assume that this project is dead/unmaintained.

The last commit was Nov 2015... which is 13 months ago.

@mattnelson
Copy link
Copy Markdown
Contributor Author

mattnelson commented Dec 31, 2016

This PR was merged only 2 months ago, so it isn't as dead as claimed.

@UrielCh Would you be able to cut a release with these changes?

@jochenberger jochenberger mentioned this pull request Mar 17, 2017
Merged
@jochenberger jochenberger mentioned this pull request Mar 27, 2017
Merged
@DirkMahler DirkMahler mentioned this pull request Jul 17, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@mattnelson @burtonator @cowst @UrielCh