fix: clean up edge functions server#310
Merged
eduardoboucas merged 4 commits intomainfrom Jun 18, 2025
Merged
Conversation
eduardoboucas
commented
Jun 18, 2025
| ps?: ExecaChildProcess | ||
| } | ||
|
|
||
| export const killProcess = (ps?: ExecaChildProcess) => { |
Member
Author
There was a problem hiding this comment.
Copied from https://github.com/netlify/build/blob/78b7da5dd5b31898b2a25d16eb1008f5fdb27e36/packages/edge-bundler/node/server/util.ts#L38. I can imagine this being useful in other situations, so I added it to @netlify/dev-utils instead of @netlify/edge-functions. We can then update @netlify/edge-bundler to use it.
pieh
reviewed
Jun 18, 2025
chee
approved these changes
Jun 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Something else I noticed when working on withastro/astro#13768 is that the edge functions server isn't being terminated when
NetlifyDev'sstop()method is called.This PR fixes that.