Skip to content

chore: pull in v0.13.13 from upstream#10

Merged
eduardoboucas merged 263 commits intonetlifyfrom
pull-in-v0.13.13
Dec 3, 2021
Merged

chore: pull in v0.13.13 from upstream#10
eduardoboucas merged 263 commits intonetlifyfrom
pull-in-v0.13.13

Conversation

@netlify-team-account-1
Copy link
Copy Markdown

@netlify-team-account-1 netlify-team-account-1 commented Nov 16, 2021

This PR pulls in all the changes since v0.13.13 from upstream. There were quite some merge conflicts in the process, but most were easily resolvable. CI is green, which gives me some confidence that everything went alright :) The tests for onDynamicImport are also still part of the repository after merging, so we know that our changes weren't deleted at some point during the merge.

closes https://github.com/netlify/pod-serverless/issues/42

evanw and others added 30 commits June 3, 2021 15:11
The Bazel nogo (Go lint config) errored when I tried to compile esbuild:

    compilepkg: nogo: errors found by nogo during build-time code analysis:
    external/com_github_evanw_esbuild/internal/bundler/linker.go:3309:27:
     exporting a pointer for the loop variable stmt (export_loop_ref)

The simplified code nogo complains about is:

    for _, stmt := range partStmts {
      stmt.Data = &js_ast.SImport{
        StarNameLoc: &stmt.Loc,
      }
    }

The problem is `&stmt.Loc` points to the mutated loop variable `stmt`.  After
the loop iteration ends, all stored pointers will point to the last value of
`partStmts[-1].Loc`.

An alternative solution is to shadow `stmt` at the beginning of the loop, but
this felt cleaner:

    stmt := stmt

The lint rule is defined by https://github.com/kyoh86/exportloopref.
@eduardoboucas eduardoboucas merged commit 5eaec45 into netlify Dec 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.