Skip to content

feat: Make graphs optional#331

Merged
danez merged 2 commits intonetlify:mainfrom
hermanschaaf:optional-graphs
Nov 24, 2022
Merged

feat: Make graphs optional#331
danez merged 2 commits intonetlify:mainfrom
hermanschaaf:optional-graphs

Conversation

@hermanschaaf
Copy link
Copy Markdown
Contributor

@hermanschaaf hermanschaaf commented Nov 22, 2022

This adds a style option that allows users to choose between the graph style and the original text style. The default is graph.

Examples

text

Screenshot 2022-11-22 at 17 26 49

graph

Screenshot 2022-11-22 at 17 28 17

This was tested here cloudquery/plugin-sdk#425

Closes #330

@hermanschaaf hermanschaaf marked this pull request as ready for review November 22, 2022 17:29
@eduardoboucas eduardoboucas requested a review from danez November 22, 2022 17:43
@danez
Copy link
Copy Markdown
Contributor

danez commented Nov 23, 2022

Thanks for the PR. Looks good so far. Could you please add a test case for this. Should be similar to the one we have right now, but with the different style.

@hermanschaaf
Copy link
Copy Markdown
Contributor Author

@danez Sure, updated the tests 👍

@danez danez merged commit 38e4750 into netlify:main Nov 24, 2022
@eduardoboucas
Copy link
Copy Markdown
Member

@hermanschaaf This is awesome, thank you! ❤️

@erezrokah
Copy link
Copy Markdown
Contributor

Thanks for the PR @hermanschaaf and the quick review and merge @danez and @eduardoboucas 🚀

@eduardoboucas
Copy link
Copy Markdown
Member

@erezrokah ❤️🥲

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Make graph rendering optional

4 participants