data collection of netfilter connection tracker metrics using netlink (libmnl)#1963
Merged
ktsaou merged 9 commits intonetdata:masterfrom Mar 18, 2017
Merged
data collection of netfilter connection tracker metrics using netlink (libmnl)#1963ktsaou merged 9 commits intonetdata:masterfrom
ktsaou merged 9 commits intonetdata:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The internal nfacct plugin:
The plugin still requires netdata to be running as root. The next step is to move it away from the netdata daemon to an external plugin, that will be setuid to root.
But in order to do this, it has to be merged with the internal netfilter plugin, so that only one method of netfilter data collection will be used at any time. So, if netlink is available it should be used, otherwise the proc filesystem should be used, but if even this is not available the plugin should stop and exit.