fix(skills): remove netclaw keyword blacklist, fix enrichment race, fix flaky test#333
Merged
Merged
Conversation
…race, fix flaky test (#328, #316) Three skill auto-loading fixes: 1. Remove "netclaw" from GenericKeywords blacklist — the token was stripped from all skill keyword indexes, making identity queries like "What version of Netclaw" unable to trigger netclaw-manual. TF-IDF weighting already handles common tokens. 2. Apply fallback keywords immediately on startup before LLM enrichment completes. Previously, fallback keywords were skipped when a chat client provider was available, leaving a race window with zero keywords. 3. Purge stale keyword cache files during RescanAndUpdateIndex so old version caches don't cause misses that force re-enrichment. Also fixes: 4. Flaky test Reconcile_disables_zombie_oneshot_reminders — PreStart's Self.Tell(ReconcileReminders) could arrive after the test's Ask, causing the startup reconcile to race with the zombie write. Fixed by draining the mailbox with two reconcile Asks before writing test data. 5. HandleReconcileAsync catch block now replies with zero-result ack so external Ask callers don't hang until timeout on transient failures.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
"netclaw"fromGenericKeywordsblacklist inSystemSkillSyncService— was preventing identity queries from triggering skill auto-loadingReconcile_disables_zombie_oneshot_reminderstest — PreStart reconcile raced with test's zombie writeHandleReconcileAsynccatch block so Ask callers don't hang on transient failuresCloses #328, closes #316
Test plan
dotnet build— cleandotnet test— 1,133 tests pass