You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
reset stale manual model-entry state before each model provider probe
add regressions for returning from manual entry to provider selection and for stale manual state before discovery results render
Verification
kubectl exec -n netclaw-support deploy/netclaw-support -- netclaw model discover openai
dotnet test src/Netclaw.Cli.Tests --filter ManualEntry_DoesNotPersistAfterReturningToProviderSelection
dotnet test src/Netclaw.Cli.Tests --filter ModelManager
dotnet test src/Netclaw.Cli.Tests
dotnet slopwatch analyze
pwsh ./scripts/Add-FileHeaders.ps1 -Verify
git diff --check
Note
The native smoke harness published binaries successfully but could not proceed because this environment lacks local Ollama and the harness attempted a sudo install without a password-capable TTY.
The provider discovery path is working here; the failure is stale TUI state.
ManualModelEntry is a substate of the model-discovery screen. If the user enters manual model-id mode, backs out to provider selection, and then selects openai again, the probe can succeed and populate DiscoveredModels, but the old ManualModelEntry == true value still causes the page to render the manual textbox instead of the discovered model list.
Resetting these fields at the start of each provider probe makes each probe a fresh model-selection attempt:
ManualModelEntry=false;SelectedModelId=null;
ManualModelEntry = false ensures the successful probe renders the selectable discovered-model list. SelectedModelId = null clears any stale model ID typed during a previous attempt so the next provider selection cannot carry old input forward.
I verified this with a baseline proof test: the regression failed on unmodified dev because ManualModelEntry remained true after backing out and selecting openai again, even though the probe returned models. The same test passes with this reset in place.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bugSomething isn't workingprovidersProvider integrations and capability detection across OpenAI-compatible backends.tuiTerminal UI (Termina) issues
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Verification
Note
The native smoke harness published binaries successfully but could not proceed because this environment lacks local Ollama and the harness attempted a sudo install without a password-capable TTY.