fix(installer): use User-scope PATH in Windows install instruction#1274
Merged
Aaronontheweb merged 3 commits intoJun 1, 2026
Merged
Conversation
…etclaw-dev#1072) The printed PATH instruction used $env:PATH, which is the merged Machine+User PATH. Writing it back to User scope copies all Machine entries into User scope, corrupting the User PATH and pushing it toward the 8191-char limit. Changed to read User scope separately before modifying: $userPath = [Environment]::GetEnvironmentVariable('PATH', 'User') [Environment]::SetEnvironmentVariable('PATH', "...;$userPath", 'User') Also added smoke test assertions to prevent regression.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
$env:PATH(merged Machine+User) instead of User scopeFixes #1072
Changes
scripts/install.ps1:
scripts/smoke/install-smoke.ps1:
$env:PATHTest plan
scripts/smoke/install-smoke.ps1)