Skip to content

Do not return prometheus metric if it is empty #669

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
leoparente merged 1 commit into from
Apr 21, 2023
Merged

Do not return prometheus metric if it is empty #669

leoparente merged 1 commit into from
Apr 21, 2023

Conversation

@leoparente
Copy link
Contributor

@leoparente leoparente commented Apr 21, 2023

No description provided.

@leoparente leoparente requested review from etaques and weyrick April 21, 2023 18:31
@leoparente leoparente self-assigned this Apr 21, 2023
etaques
etaques approved these changes Apr 21, 2023
View reviewed changes
Copy link
Contributor

@etaques etaques left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@leoparente leoparente merged commit 087e1da into develop Apr 21, 2023
@leoparente leoparente deleted the feature/dont-send-prometheus-if-empty branch April 21, 2023 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@weyrick weyrick Awaiting requested review from weyrick

1 more reviewer

@etaques etaques etaques approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@leoparente leoparente

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@leoparente @etaques