specify required Conan version in README #640
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Conan 2.0.1 is now the version being distributed by pip, which means that your Docker builds are also broken. It would be simple enough to specify a 1.X version in the Dockerfile, but I assume you will want to fix this properly. There is a migration guide but unfortunately I know nothing about Conan (or CMAKE for that matter) so I can't contribute the fix myself. |
Contributor
leoparente
approved these changes
Mar 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While building pktvisor I encountered an error which led me to discover that pktvisor will not build with the latest version of Conan. In Conan 2.X,
--install-folderhas been deprecated. I downgraded my local Conan to version 1.59.0 (the latest pre-2.X release) and was able to build successfully.