Skip to content

Conversation

@leoparente
Copy link
Contributor

No description provided.

@leoparente leoparente requested a review from weyrick January 8, 2023 23:40
@leoparente leoparente self-assigned this Jan 8, 2023
@weyrick
Copy link
Contributor

weyrick commented Jan 9, 2023

I see this involves some pretty low level bit copying. We'll need to make sure we have enough test cases to cover proper bounds checking, ensuring things aren't null, have enough space to copy to, etc. Let's make sure invalid/unexpected input cannot cause a failure here.

@leoparente
Copy link
Contributor Author

I see this involves some pretty low level bit copying. We'll need to make sure we have enough test cases to cover proper bounds checking, ensuring things aren't null, have enough space to copy to, etc. Let's make sure invalid/unexpected input cannot cause a failure here.

Yes, Agreed. That is why I used std::array with enough space for IPV4 and IPV6.. and regarding Netflow V9 and IPFIX be_copy logic ensures that: only copy if there is enough space

@leoparente leoparente changed the title Bugfix/netflow support ipv6 [PKT-61] Bugfix/netflow support ipv6 Jan 9, 2023
@leoparente leoparente merged commit 3274caf into develop Jan 11, 2023
@leoparente leoparente deleted the bugfix/netflow-support-ipv6 branch January 11, 2023 01:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants