Skip to content

Implement network interface scan and pick default tap #373

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
leoparente merged 5 commits into from
Aug 26, 2022
Merged

Implement network interface scan and pick default tap #373

leoparente merged 5 commits into from
Aug 26, 2022

Conversation

@leoparente
Copy link
Contributor

@leoparente leoparente commented Aug 18, 2022

No description provided.

@leoparente leoparente self-assigned this Aug 18, 2022
@leoparente leoparente linked an issue Aug 18, 2022 that may be closed by this pull request
setup default taps at startup if none specified #152
Closed
@leoparente leoparente force-pushed the feature/default-tap-pick branch 4 times, most recently from f015d21 to f54d6a7 Compare August 18, 2022 13:27
@leoparente leoparente force-pushed the feature/default-tap-pick branch from f54d6a7 to 723c6b9 Compare August 18, 2022 13:52
@leoparente
Copy link
Contributor Author

leoparente commented Aug 18, 2022 •
edited
Loading

For Mac OS I was able only to validate the build, not the feature itself.
Tested in my local environment (Linux) and it seems to be working properly.

@leoparente
Copy link
Contributor Author

leoparente commented Aug 19, 2022

@weyrick need you to build and test this feature on MAC OS.

weyrick
weyrick requested changes Aug 23, 2022
View reviewed changes
@leoparente leoparente requested a review from weyrick August 25, 2022 18:52
@leoparente leoparente merged commit 76baa46 into develop Aug 26, 2022
@leoparente leoparente deleted the feature/default-tap-pick branch August 26, 2022 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@weyrick weyrick weyrick approved these changes

@rboucher-me rboucher-me Awaiting requested review from rboucher-me

Assignees

@leoparente leoparente

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

setup default taps at startup if none specified

3 participants

@leoparente @weyrick