Create dnstap_msg_type filter in DNS handler #216
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weyrick
reviewed
Feb 18, 2022
| _f_dnstap_types.set(type_pair.second); | ||
| _f_enabled.set(Filters::DnstapMsgType); | ||
| } catch (const std::exception &e) { | ||
| throw ConfigException(fmt::format("dnstap_msg_type error {}", e.what())); |
Contributor
There was a problem hiding this comment.
let's go ahead and dump the keys in _dnstap_map_types in this message so the user knows which they can set
| new_event(stamp); | ||
| // process in the "live" bucket. this will parse the resources if we are deep sampling | ||
| if (filtered) { | ||
| live_bucket()->process_filtered(); |
Contributor
There was a problem hiding this comment.
shouldn't this have a return after it, or the process_dnstap below be in an else { } ? i'm confused why the unit test passes if so.
Author
There was a problem hiding this comment.
I've called livebucket here that only performs
void DnsMetricsBucket::process_filtered()
{
std::unique_lock lock(_mutex);
++_counters.filtered;
}
should I change the logic here to call metricsManager process_filtered and return?
Contributor
There was a problem hiding this comment.
right calling process_filtered is good, but then it goes on to call process_dnstap with the payload, which means it would actually count all those metrics and not really filter it right?
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.