Merged
Conversation
I could not find anything to confirm that keepassx supports hardware keys. And as mentioned by @rusty-snake[1]: > The yubikey support in kpxc seems to be based on > https://github.com/kylemanna/keepassx / > keepassx/keepassx#52 > which was never merged. For me it looks like kpx never got official > support for it. > > keepass seems to support hw keys (via plugin). Also of note is the PR that added yubikey support to keepassxc: keepassxreboot/keepassxc#127 This partially reverts commit 09ac1a7 ("keepass*: remove nou2f", 2022-02-05) / PR netblue30#4903. See also commit 91b0417 ("keepass*: fix typo in private-dev note", 2022-02-06). Closes netblue30#4883. [1] netblue30#4883 (comment)
rusty-snake
approved these changes
Feb 7, 2022
Fred-Barclay
approved these changes
Feb 9, 2022
Collaborator
Fred-Barclay
left a comment
There was a problem hiding this comment.
Looks good to me, thanks!
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I could not find anything to confirm that keepassx supports hardware
keys. And as mentioned by @rusty-snake[1]:
Also of note is the PR that added yubikey support to keepassxc:
keepassxreboot/keepassxc#127
This partially reverts commit 09ac1a7 ("keepass*: remove nou2f",
2022-02-05) / PR #4903. See also commit 91b0417 ("keepass*: fix typo
in private-dev note", 2022-02-06).
Closes #4883.
[1] #4883 (comment)