Correctly set address length in arp frames#2327
Merged
netblue30 merged 1 commit intonetblue30:masterfrom Jan 7, 2019
Merged
Conversation
Kernel commit 99137b7 introduced an additional check of the address length. This exposed a bug in the arp code where the address length was being set incorrectly. Now the length is set from the ETH_ALEN constant declared in linux/if_ether.h This fixes #2314
|
We need to have this merged asap. |
|
Tried it on Archlinux with kernel 4.20.0, all good 👍 |
Owner
|
Thanks for the fix, I'll make sure it goes on all our branches. |
|
Thanks! Great work! |
minus7
reviewed
Jan 9, 2019
| @@ -78,7 +78,7 @@ void arp_announce(const char *dev, Bridge *br) { | |||
| errExit("if_nametoindex"); | |||
| addr.sll_family = AF_PACKET; | |||
| memcpy (addr.sll_addr, ifr.ifr_hwaddr.sa_data, 6); | |||
Contributor
There was a problem hiding this comment.
Is it fine to keep the hardcoded 6 here?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Kernel commit 99137b7 introduced an additional check of the address
length. This exposed a bug in the arp code where the address length was
being set incorrectly.
Now the length is set from the
ETH_ALENconstant declared inlinux/if_ether.h.This fixes #2314