Fix NOHOST flag on IPNetwork copy constructor#375
Merged
jstasiak merged 2 commits intonetaddr:masterfrom Feb 20, 2024
Merged
Conversation
Add tests for NOHOST flag
jstasiak
reviewed
Feb 19, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #375 +/- ##
==========================================
+ Coverage 85.72% 86.08% +0.35%
==========================================
Files 47 47
Lines 4379 4384 +5
Branches 737 738 +1
==========================================
+ Hits 3754 3774 +20
+ Misses 449 434 -15
Partials 176 176 ☔ View full report in Codecov by Sentry. |
Contributor
|
Thank you |
Contributor
|
Released in netaddr 1.3.0. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add tests for NOHOST flag
Fixes #374