Conversation
This is one of the pieces missing to have a good IPv4-mapped IPv6 address handling story. Following Rust's IpAddr::to_canonical() design[1][2][3] which seems sensible to me (except that ours is simpler as we don't have separate types for IPv4 and IPv6 addresses – yet). Also, relying on doctests[4] to test this feature – no need to make things more difficult than they need to be. [1] https://doc.rust-lang.org/std/net/enum.IpAddr.html#method.to_canonical [2] https://doc.rust-lang.org/std/net/struct.Ipv6Addr.html#method.to_canonical [3] rust-lang/rust#87708 [4] 3290b50 ("Make pytest run doctests (#280)")
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #287 +/- ##
==========================================
+ Coverage 85.47% 85.53% +0.05%
==========================================
Files 48 48
Lines 4579 4583 +4
Branches 805 806 +1
==========================================
+ Hits 3914 3920 +6
+ Misses 482 478 -4
- Partials 183 185 +2 ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is one of the pieces missing to have a good IPv4-mapped IPv6 address handling story.
Following Rust's IpAddr::to_canonical() design[1][2][3] which seems sensible to me (except that ours is simpler as we don't have separate types for IPv4 and IPv6 addresses – yet).
Also, relying on doctests[4] to test this feature – no need to make things more difficult than they need to be.
[1] https://doc.rust-lang.org/std/net/enum.IpAddr.html#method.to_canonical
[2] https://doc.rust-lang.org/std/net/struct.Ipv6Addr.html#method.to_canonical
[3] rust-lang/rust#87708
[4] 3290b50 ("Make pytest run doctests (#280)")