Conversation
This is a cherry pick of commit [1] later temporarily reverted in [2] to
unblock the 0.8.0 release.
The original commit message:
Like RFC 3021, IPv6 defines point-to-point subnets that must
be handled separately, i.e. don't reserve first IP address.
This patch aims to implement this, while refactoring code in
iter_host function to reduce code duplication.
Tests for this feature also added to ensure there is no regression.
Signed-off-by: Damien Claisse <d.claisse@criteo.com>
We're preparing 0.9.0 release so this can land again (for good this
time).
[1] 2984c0a ("Handle RFC 6164 IPv6 addresses")
[2] 67f1992 ("Revert "Handle RFC 6164 IPv6 addresses"")
Codecov ReportPatch coverage:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #267 +/- ##
==========================================
+ Coverage 85.32% 85.34% +0.02%
==========================================
Files 48 48
Lines 4566 4573 +7
Branches 706 805 +99
==========================================
+ Hits 3896 3903 +7
Misses 488 488
Partials 182 182
☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a cherry pick of commit [1] later temporarily reverted in [2] to unblock the 0.8.0 release.
The original commit message:
We're preparing 0.9.0 release so this can land again (for good this time).
[1] 2984c0a ("Handle RFC 6164 IPv6 addresses")
[2] 67f1992 ("Revert "Handle RFC 6164 IPv6 addresses"")