Skip to content

Fix for is_loopback behaviour (issue: #222)#223

Merged
jstasiak merged 3 commits intonetaddr:masterfrom
nkeulen:master
Jan 27, 2021
Merged

Fix for is_loopback behaviour (issue: #222)#223
jstasiak merged 3 commits intonetaddr:masterfrom
nkeulen:master

Conversation

@nkeulen
Copy link
Contributor

@nkeulen nkeulen commented Jan 27, 2021

No description provided.

Copy link
Contributor

@jstasiak jstasiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, this looks sensible. Can you add a unit test or modify an existing one?

@nkeulen
Copy link
Contributor Author

nkeulen commented Jan 27, 2021

Thank you, this looks sensible. Can you add a unit test or modify an existing one?

I've added a unit test file: test_ip_network_categories.py,
which mirrors what was done for IPAddress in test_ip_categories.py but for IPNetwork instead.

@jstasiak
Copy link
Contributor

Just the test_is_loopback test would be enough, but thanks!

@jstasiak jstasiak merged commit 606a44b into netaddr:master Jan 27, 2021
@jstasiak
Copy link
Contributor

Released in version 0.9.0 today.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants