feat(): add support for manual init#1766
Merged
kamilmysliwiec merged 1 commit intonestjs:masterfrom Oct 26, 2023
Merged
Conversation
1 task
|
Anything holding this back from getting merged in? I could definitely make use of it. |
Member
|
LGTM |
|
Any indication when this change might be published to npm? |
Looks like it was release in v10.0.1 |
The same day as my comment! Was maybe a day early 😮💨 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
Motivation for no tests:
I searched repository for proper place to add tests for this feature but none seem to be correct (there are only e2e tests with specific convention).
I run e2e suite though and it passes.
I also tested the feature manually on my usecase (on and off).
Please suggest test convention if you want me to write tests for this feature and I will do my best to apply it.
PR Type
What kind of change does this PR introduce?
What is the current behavior?
There is no option to disable
DataSourceinitialization during module initializationIssue Number: 1762
What is the new behavior?
Option
manualInitializationwas added toTypeOrmModuleOptionsinterface.Module does not initialize database if option is set to
true.Does this PR introduce a breaking change?
Other information
I have done one minor refactor to limit logic repetition