fix(provider): return proper repository#1333
Merged
kamilmysliwiec merged 2 commits intonestjs:masterfrom Aug 11, 2022
Merged
Conversation
check if the entity has tree metadata and return a tree repository if it exists
Contributor
Author
|
@kamilmysliwiec any update ? |
micalevisk
reviewed
Jul 11, 2022
micalevisk
reviewed
Jul 11, 2022
|
I am waiting this PR is merged |
Contributor
Author
|
@micalevisk @kamilmysliwiec any plans on merging this PR ? |
Member
|
you can use I don't have permissions to merge PRs |
Contributor
Author
|
@micalevisk we are already using patch-package for this, but that's not the ideal thing |
Contributor
Author
|
@kamilmysliwiec any idea if this can be merged or not ? |
4 tasks
micalevisk
approved these changes
Aug 10, 2022
Member
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
check if the entity has tree metadata and return a tree repository if it exists
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Currently the providers don't return a TreeRepository for tree entities.
What is the new behavior?
Now the provider will create and return a tree repository for tree entities
Does this PR introduce a breaking change?
Other information