fix(swagger): support const enum query params#3910
Merged
kamilmysliwiec merged 1 commit intoMay 14, 2026
Conversation
Member
|
lgtm |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
When SWC emits const enum metadata as an object for a query parameter type,
SchemaObjectFactory#createQueryOrParamSchema()treats that object as a literal object schema. That produces nested property metadata instead of an OpenAPI enum schema for the parameter.Issue Number: Fixes #3909
What is the new behavior?
createQueryOrParamSchema()now recognizes const-enum-like object metadata before the generic object literal branch and emits a parameter schema withtypeandenumvalues.A regression test covers a query parameter whose
typeis a const-enum-style object.Does this PR introduce a breaking change?
Other information
Local checks:
npm test -- test/services/schema-object-factory.spec.tsnpm run buildnpm run lint(passes with existing warnings outside this change)git diff --check