fix(plugin): handle IsIn enum inference when type falls back to Object#3876
Merged
kamilmysliwiec merged 1 commit intoApr 27, 2026
Merged
Conversation
7d9755d to
9a3745b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
classValidatorShimcan emitenummetadata from@IsIn(...), but when the plugin falls back totype: () => Objectfor a literal-union property, 11.4.1 keepstype: objectin the generated schema. That produces an invalid schema for downstream tools.Issue Number: N/A
What is the new behavior?
When schema metadata has
enumand the inferred type is the plugin fallbackObject,SchemaObjectFactorynow infers the scalar schema type from the enum values instead of keepingobject.Example output:
{ "type": "string", "enum": ["a", 1] }Does this PR introduce a breaking change?
Other information
test/services/schema-object-factory.spec.tsfortype: () => Object+enummetadata.test/plugin/model-class-visitor.spec.tsfor@IsIn(['a', 1])on a literal-union property.