Skip to content

fix: type import syntax for ApiResponse in esmCompatible#3413

Merged
kamilmysliwiec merged 1 commit intonestjs:masterfrom
CatsMiaow:master
Apr 22, 2025
Merged

fix: type import syntax for ApiResponse in esmCompatible#3413
kamilmysliwiec merged 1 commit intonestjs:masterfrom
CatsMiaow:master

Conversation

@CatsMiaow
Copy link
Copy Markdown
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

What is the current behavior?

Issue Number: #3399

Fixes an issue where the esmCompatible option in the swagger plugin fails to load the ApiResponse type when using tsc.

image
  • ✅ esm + swc
  • ❌ esm + tsc

What is the new behavior?

image
  • ✅ esm + tsc

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

image

Copy link
Copy Markdown
Contributor

@seonggukchoi seonggukchoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@kamilmysliwiec kamilmysliwiec merged commit a6bf09c into nestjs:master Apr 22, 2025
1 check passed
@kamilmysliwiec
Copy link
Copy Markdown
Member

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants