acceptRanges property#1712
Merged
Merged
Conversation
Contributor
Author
|
Hi @kamilmysliwiec , do you mind taking a look at this and merging it in? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
This proposed change exposes an existing Express
serve-staticoption that is currently not available in this@nestjs/serve-staticpackage.See
acceptRangesin theserve-staticdocs: https://expressjs.com/en/resources/middleware/serve-static.htmlDoes this PR introduce a breaking change?
This is an additive change where the native Express
serve-staticproperty already exists.Other information
The areas in which this native Express
serve-staticproperty would be used are:serve-static/lib/loaders/express.loader.ts
Line 60 in afdc74b
serve-static/lib/loaders/express.loader.ts
Line 69 in afdc74b