Skip to content

acceptRanges property#1712

Merged
kamilmysliwiec merged 1 commit into
nestjs:masterfrom
Elte156:acceptRanges-option
Oct 10, 2025
Merged

acceptRanges property#1712
kamilmysliwiec merged 1 commit into
nestjs:masterfrom
Elte156:acceptRanges-option

Conversation

@Elte156

@Elte156 Elte156 commented Jun 20, 2025

Copy link
Copy Markdown
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

This proposed change exposes an existing Express serve-static option that is currently not available in this @nestjs/serve-static package.

See acceptRanges in the serve-static docs: https://expressjs.com/en/resources/middleware/serve-static.html

Does this PR introduce a breaking change?

  • Yes
  • No

This is an additive change where the native Express serve-static property already exists.

Other information

The areas in which this native Express serve-static property would be used are:

  1. express.static(clientPath, options.serveStaticOptions)
  2. app.use(express.static(clientPath, options.serveStaticOptions));

@Elte156

Elte156 commented Oct 9, 2025

Copy link
Copy Markdown
Contributor Author

Hi @kamilmysliwiec , do you mind taking a look at this and merging it in?

@kamilmysliwiec kamilmysliwiec merged commit fc977ca into nestjs:master Oct 10, 2025
1 check passed
@kamilmysliwiec kamilmysliwiec added the enhancement New feature or request label Oct 10, 2025
@Elte156 Elte156 deleted the acceptRanges-option branch October 10, 2025 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants