Synchronously copy files when watchAssets: false#2293
Merged
kamilmysliwiec merged 1 commit intonestjs:masterfrom Oct 23, 2023
Merged
Synchronously copy files when watchAssets: false#2293kamilmysliwiec merged 1 commit intonestjs:masterfrom
kamilmysliwiec merged 1 commit intonestjs:masterfrom
Conversation
bc921eb to
8f4478e
Compare
8f4478e to
20df14c
Compare
20df14c to
e19c2d3
Compare
4 tasks
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Even if watchAssets flag is false, the running
nest startprocess can't exit from entry file because chokidar watches files and entry script runs as another child process when using webpack.The reason why is internal
runWebpackmethod doesn't callassetsManager.closeWatchers()when usingnest start, butnest builddoes. At first, simply I tried to callassetsManager.closeWatchers()after onSuccess in compiler/webpack but, it can't listen to complete all entry file's processes. Additionally, current chokidar watcher can't detect whether all files matched by glob patterns is copied, so I think it would be better to process them synchronously when watchAssets: false is specified.Issue Number: N/A
What is the new behavior?
Copy files process runs Synchronously.
Does this PR introduce a breaking change?
Other information