fix(swc): don't set missing class fields#2155
Merged
kamilmysliwiec merged 1 commit intonestjs:masterfrom Jul 11, 2023
Merged
Conversation
SWC adopts ESNext behaviour of explicitly setting fields as `undefined` by default. Disabling this behaviour aligns better with TS that targets ES2021
Member
|
LGTM ❤️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
SWC adopts ESNext behaviour of explicitly setting fields as
undefinedby default. Disabling this behaviour aligns better with TS that targets ES2021.The result is as following:
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information
Relates to swc-project/swc#3459
Reproduction repo available https://github.com/tuxmachine/swc-class-transformer