Skip to content

test(sample-28): add unit and e2e tests for sse#16409

Merged
kamilmysliwiec merged 1 commit into
nestjs:v12.0.0from
zaewc:test/sample-28-sse
Feb 22, 2026
Merged

test(sample-28): add unit and e2e tests for sse#16409
kamilmysliwiec merged 1 commit into
nestjs:v12.0.0from
zaewc:test/sample-28-sse

Conversation

@zaewc

@zaewc zaewc commented Feb 21, 2026

Copy link
Copy Markdown

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe: Add missing unit and e2e tests to sample application

What is the current behavior?

Issue Number: #1539

What is the new behavior?

Added unit tests (AppController) and e2e tests (app.e2e-spec.ts) to the sample-28-sse application to ensure the SSE functionality works as expected

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Related to testing improvements across sample applications

@zaewc zaewc changed the title test(sample): add unit and e2e tests for sse test(sample-28): add unit and e2e tests for sse Feb 21, 2026
@coveralls

Copy link
Copy Markdown

Pull Request Test Coverage Report for Build cce97829-0abb-4567-b08b-26b786505cc1

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 89.863%

Totals Coverage Status
Change from base Build 686e685e-1e78-471a-bebf-44d42af2d077: 0.0%
Covered Lines: 7473
Relevant Lines: 8316

💛 - Coveralls

@kamilmysliwiec

Copy link
Copy Markdown
Member

Could you rebase to v12.0.0 branch?

@zaewc zaewc force-pushed the test/sample-28-sse branch from a41ef31 to 4cf1901 Compare February 22, 2026 06:52
@zaewc zaewc changed the base branch from master to v12.0.0 February 22, 2026 06:53
@zaewc

zaewc commented Feb 22, 2026

Copy link
Copy Markdown
Author

@kamilmysliwiec

Could you rebase to v12.0.0 branch?

Rebased onto the v12.0.0 branch
Since this branch uses Vitest, I’ve also migrated the test files from Jest to Vitest

@kamilmysliwiec kamilmysliwiec merged commit 6b278af into nestjs:v12.0.0 Feb 22, 2026
1 check passed
@kamilmysliwiec

Copy link
Copy Markdown
Member

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants