Skip to content

test(sample-20): add e2e and unit tests for caching functionality#16406

Merged
kamilmysliwiec merged 1 commit into
nestjs:v12.0.0from
zaewc:test/sample-20-cache
Mar 1, 2026
Merged

test(sample-20): add e2e and unit tests for caching functionality#16406
kamilmysliwiec merged 1 commit into
nestjs:v12.0.0from
zaewc:test/sample-20-cache

Conversation

@zaewc

@zaewc zaewc commented Feb 21, 2026

Copy link
Copy Markdown

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

What is the current behavior?

Issue Number: #1539

What is the new behavior?

Added unit tests (AppController, HttpCacheInterceptor) and e2e tests (app.e2e-spec.ts) to the sample-20-cache application.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

This PR added unit and e2e tests to the sample-20-cache

@coveralls

Copy link
Copy Markdown

Pull Request Test Coverage Report for Build 6d45dbc5-6a63-40e1-9af3-090e679c25bf

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 89.863%

Totals Coverage Status
Change from base Build ddc230fc-9dc4-430d-be00-8d640800740c: 0.0%
Covered Lines: 7473
Relevant Lines: 8316

💛 - Coveralls

@kamilmysliwiec

Copy link
Copy Markdown
Member

Could you rebase to v12.0.0 branch?

@zaewc zaewc force-pushed the test/sample-20-cache branch from ca85bdd to 389d68c Compare March 1, 2026 09:14
@zaewc zaewc changed the base branch from master to v12.0.0 March 1, 2026 09:31
@zaewc

zaewc commented Mar 1, 2026

Copy link
Copy Markdown
Author

@kamilmysliwiec

Could you rebase to v12.0.0 branch?

Rebased onto the v12.0.0 branch
Since this branch uses Vitest, I’ve also migrated the test files from Jest to Vitest

@kamilmysliwiec kamilmysliwiec merged commit 6cee276 into nestjs:v12.0.0 Mar 1, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants