refactor: migrate from mocha, chai, sinon to vitest#16370
Merged
kamilmysliwiec merged 18 commits intobuild/esm-migrationfrom Feb 15, 2026
Merged
refactor: migrate from mocha, chai, sinon to vitest#16370kamilmysliwiec merged 18 commits intobuild/esm-migrationfrom
kamilmysliwiec merged 18 commits intobuild/esm-migrationfrom
Conversation
feat: standard schema validation pipe, and standard serializer, introduce internal export subpath
refactor: minor codebase tweaks
sample: migrate all samples to esm and vitest
Dunqing
reviewed
Feb 24, 2026
Comment on lines
+23
to
+37
| swc.vite({ | ||
| module: { type: 'es6' }, | ||
| jsc: { | ||
| target: 'es2022', | ||
| parser: { | ||
| syntax: 'typescript', | ||
| decorators: true, | ||
| }, | ||
| transform: { | ||
| legacyDecorator: true, | ||
| decoratorMetadata: true, | ||
| }, | ||
| keepClassNames: true, | ||
| }, | ||
| }), |
There was a problem hiding this comment.
Just a heads up, the next version of Vitest (currently still in beta vitest@4.1.0-beta.4) uses Vite 8 under the hood, which uses oxc to transform. It has a built-in legacy decorator transform and also supports emitting decorator metadata, so that no SWC is needed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
TODO: some integration tests are currently excluded, waiting for other Nest packages to get migrated to ESM
Does this PR introduce a breaking change?
Other information