fix(common): resolve file-type path explicitly#16077
Merged
kamilmysliwiec merged 2 commits intoDec 15, 2025
Merged
Conversation
Pull Request Test Coverage Report for Build 9d9b0d55-7264-4e48-a13d-b705ee67d42aDetails
💛 - Coveralls |
This was referenced Dec 15, 2025
4 tasks
12 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
The
FileTypeValidatorusesloadEsm('file-type')which can resolve to an incorrect version offile-typein monorepos or when dependencies are hoisted, leading to validation failures with cryptic error messages.Issue Number: #15270
What is the new behavior?
The validator now explicitly resolves the path to the
file-typedependency usingrequire.resolve('file-type')before importing it. This ensures that the version offile-typedeclared in@nestjs/commonis used.Does this PR introduce a breaking change?