pref():import lodash efficiently#1446
Merged
kamilmysliwiec merged 1 commit intonestjs:masterfrom Aug 31, 2023
Merged
Conversation
this is the recommended way to load only the methods needed instead of entire lodash.
15685c1 to
5f267d1
Compare
micalevisk
approved these changes
Aug 30, 2023
Member
|
lgtm |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this is the recommended way to load only the methods needed instead of entire lodash.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
lodash is imported entirely in to the package. when most of it not needed at all.
it makes 78.3% of the bundle!
Issue Number: N/A
What is the new behavior?
imports only the relevant methods. This is the recommended way to pick methods from lodash.
This improves pull request 792, which moved to using the full lodash package,
but made inefficient imports.
Does this PR introduce a breaking change?
Other information
pull request improved: #792
article about importing lodash: https://www.labnol.org/code/import-lodash-211117