Skip to content

feat: Support set start block number for multisig address#3176

Merged
yanguoyu merged 2 commits intonervosnetwork:developfrom
yanguoyu:feat-multi-sync
Jun 4, 2024
Merged

feat: Support set start block number for multisig address#3176
yanguoyu merged 2 commits intonervosnetwork:developfrom
yanguoyu:feat-multi-sync

Conversation

@yanguoyu
Copy link
Contributor

@yanguoyu yanguoyu commented May 28, 2024

2024-05-28.23.15.18.mov

Refer to Magickbase/neuron-public-issues#353

@yanguoyu yanguoyu mentioned this pull request May 28, 2024
Closed
@Danie0918 Danie0918 requested a review from twhy May 29, 2024 12:33
@Danie0918
Copy link

Danie0918 commented May 30, 2024

@homura @devchenyan @twhy Please have a review.

@Danie0918
Copy link

Danie0918 commented May 31, 2024

@homura @devchenyan @twhy Please have a review.

cc @homura @devchenyan @twhy

twhy
twhy reviewed May 31, 2024
View reviewed changes
homura
homura approved these changes May 31, 2024
View reviewed changes
@silySuper
Copy link

silySuper commented May 31, 2024 •
edited by github-actions bot
Loading

/package
Packaging for test is done in 9314286132. @silySuper

@silySuper
Copy link

silySuper commented May 31, 2024

When multisig address is syncing,light client node is stop syncing?this requirement is to let multisig address sync can not stoping light client node sync? @Danie0918
截屏2024-05-31 17 33 42

@yanguoyu
Copy link
Contributor Author

yanguoyu commented May 31, 2024

When multisig address is syncing,light client node is stop syncing?this requirement is to let multisig address sync can not stoping light client node sync? @Danie0918 截屏2024-05-31 17 33 42

Magickbase/neuron-public-issues#353 (comment)
When syncing multisig, the wallet sync will stop.

@Danie0918
Copy link

Danie0918 commented May 31, 2024 •
edited
Loading

When multisig address is syncing,light client node is stop syncing?this requirement is to let multisig address sync can not stoping light client node sync? @Danie0918 截屏2024-05-31 17 33 42

Yes, but the display here could be optimized: show 'Sync Pause' or '--' to avoid worrying the user.

BTW, the red alert tip does feel like a bug, and if UI is needed, it's up to me to move forward with the design. @yanguoyu

@silySuper
Copy link

silySuper commented Jun 3, 2024 •
edited by github-actions bot
Loading

/package
Packaging for test is done in 9345190912. @silySuper

@yanguoyu yanguoyu enabled auto-merge June 4, 2024 06:48
@yanguoyu yanguoyu added this pull request to the merge queue Jun 4, 2024
Merged via the queue into nervosnetwork:develop with commit 29ba444 Jun 4, 2024
@yanguoyu yanguoyu deleted the feat-multi-sync branch June 4, 2024 12:14
@Keith-CY Keith-CY mentioned this pull request Aug 8, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Keith-CY Keith-CY Awaiting requested review from Keith-CY

4 more reviewers

@twhy twhy twhy approved these changes

@homura homura homura approved these changes

@devchenyan devchenyan devchenyan approved these changes

@silySuper silySuper silySuper approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@yanguoyu @Danie0918 @silySuper @twhy @homura @devchenyan