Skip storing all zero cycles in db when disable script#4452
Merged
zhangsoledad merged 2 commits intonervosnetwork:developfrom May 10, 2024
Merged
Conversation
eval-exec
reviewed
May 10, 2024
Collaborator
eval-exec
left a comment
There was a problem hiding this comment.
How about change ContextualBlockVerifier::verifier's return type to Option<Cycle, ...>?
zhangsoledad
approved these changes
May 10, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
When run
ckb runwithout disablingassume-valid-target, all the cycles in blocks are zero, since we skipped verification in this scenario.What is changed and how it works?
Don't store all zeros in db, set
ext.cyclesto None.Check List
Tests
Release note