build: customize opt-level to avoid building some crates twice#2788
Merged
bors[bot] merged 1 commit intonervosnetwork:developfrom Jun 28, 2021
Merged
Conversation
driftluo
approved these changes
Jun 25, 2021
quake
approved these changes
Jun 27, 2021
Member
|
bors r=quake,driftluo |
Contributor
|
Build succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Since "Cargo PR-8500" merged, as "Cargo Issue-8502" said: "if a crate will also be built as a runtime dependency, that would result in Cargo building it twice, once with opt-level 0 and once with opt-level 3."
So, in this PR I customize the
opt-levelto the default values, to make sure each crates only be compiled once.Results
When
make prodforv0.42.0:596 -> 544).1_813_100 bytes -> 1_587_780 bytes).Notice: the size of final binary won't be chaneged.
References