fix(api): substitute calls on_bytes after modifying buffer#36650
Merged
github-actions[bot] merged 1 commit intorelease-0.11from Nov 21, 2025
Merged
fix(api): substitute calls on_bytes after modifying buffer#36650github-actions[bot] merged 1 commit intorelease-0.11from
substitute calls on_bytes after modifying buffer#36650github-actions[bot] merged 1 commit intorelease-0.11from
Conversation
Problem: `extmark_splice()` was being called before `ml_replace()`, which caused the on_bytes callback to be invoked with the old buffer text instead of the new text. Solution: store metadata for each match in a growing array, call `ml_replace()` once to update the buffer, then call `extmark_splice()` once per match. Closes #36370. (cherry picked from commit 7da4d6a)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Backport of #36487 to
release-0.11.