Skip to content

deps: Fix luv-static build issues#11961

Merged
justinmk merged 1 commit intoneovim:masterfrom
erw7:deps-luv-static
Feb 29, 2020
Merged

deps: Fix luv-static build issues#11961
justinmk merged 1 commit intoneovim:masterfrom
erw7:deps-luv-static

Conversation

@erw7
Copy link
Copy Markdown
Contributor

@erw7 erw7 commented Feb 29, 2020

  • Fix an issue where CMAKE_BUILD_TYPE was not reflected during construction.
  • Remove the switch that uses the static library(-MTd, -MT) because it was specified in the CMakeLists.txt of luv when building on MSVC.

@erw7
deps: Fix luv-static build issues
d8305d3 
- Fix an issue where CMAKE_BUILD_TYPE was not reflected during
  construction.
- Remove the switch that uses the static library(-MTd, -MT) because it was
  specified in the CMakeLists.txt of luv when building on MSVC.
@marvim marvim added the WIP label Feb 29, 2020
@erw7 erw7 changed the title [WIP] deps: Fix luv-static build issues deps: Fix luv-static build issues Feb 29, 2020
@justinmk justinmk merged commit 78f1ecc into neovim:master Feb 29, 2020
@justinmk
Copy link
Copy Markdown
Member

justinmk commented Feb 29, 2020

Thanks @erw7 is this related to luvit/luv#461 ? It is very helpful to mention references.

@justinmk justinmk added build building and installing Neovim using the provided scripts lua stdlib and removed WIP labels Feb 29, 2020
@erw7
Copy link
Copy Markdown
Contributor Author

erw7 commented Mar 1, 2020

is this related to luvit/luv#461 ?

No. In CMakeLists.txt of luv, replace /MD with /MT after this commit (luvit/luv@7f6ad65#diff-af3b638bc2a3e6c650974192a53c7291R116). Therefore, we should not need to specify -MTd and -MT in BuildLuv.cmake.

Another problem was that luv-static was always built with the default configuration, regardless of CMAKE_BUILD_TYPE. I think it is easy to understand the case of MSVC build. Because the default configuration of MSVC is Debug, luv-static was always built with Debug as shown in the following log.

https://ci.appveyor.com/project/neovim/neovim/builds/31091046/job/090r08i1k76a4kgo?fullLog=true#L10590

@erw7 erw7 deleted the deps-luv-static branch March 1, 2020 07:04
@janlazo janlazo mentioned this pull request May 12, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

build building and installing Neovim using the provided scripts lua stdlib

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@erw7 @justinmk @marvim