-
-
Notifications
You must be signed in to change notification settings - Fork 202
Bug: Store Sorting inconsistencies with Turbo Mode (Lazy Records) #9066
Copy link
Copy link
Closed
Labels
bugSomething isn't workingSomething isn't workingcoreCore framework functionalityCore framework functionality
Description
Investigate and fix sorting behavior in Neo.data.Store when "Turbo Mode" (autoInitRecords: false) is active.
Symptom:
In DevRank, toggling the "Commits Only" checkbox triggers a sort on a different field (total_commits vs total_contributions). The user observed that "only the mounted row-range gets resorted".
Hypothesis:
When autoInitRecords is false, the Store holds a mix of Neo.data.Model instances (for accessed records) and raw JSON objects (for unaccessed records).
If the Sorter uses a property that exists on the Model (e.g. a calculated field like total_commits) but not on the raw JSON, the sort logic might fail or produce inconsistent results for the uninitialized records.
Task:
- Analyze
Neo.data.Store.doSortandNeo.collection.Sorter. - Determine if the Sorter correctly handles raw vs. record data.
- Implement a fix:
- Option A: Force initialization of all records before sorting (heavy).
- Option B: Ensure the Sorter can read/calculate fields from raw data (preferred for performance).
- Verify fix in DevRank grid.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
bugSomething isn't workingSomething isn't workingcoreCore framework functionalityCore framework functionality