Skip to content

Remove obsolete component management logic from Grid.Body #9018

@tobiu

Description

@tobiu

Objective:
Remove clearComponentColumnMaps and cleanupComponentInstances methods from Neo.grid.Body. These methods are obsolete artifacts from the pre-Row-Pooling architecture and are causing crashes (TypeError: Cannot read properties of undefined (reading 'forEach')) because column.map no longer exists.

Context:

  • Old Architecture: GridBody managed component instances (e.g., Sparklines) using column.map.
  • New Architecture: Neo.grid.Row manages its own component instances in this.components and cleans them up in its destroy() method.
  • The Bug: Unit tests exposed that GridBody was still attempting to access column.map during destroy() and onStoreLoad(), causing a hard crash.

Changes Required:

  1. File: src/grid/Body.mjs
  2. Action: Delete clearComponentColumnMaps and cleanupComponentInstances.
  3. Action: Remove calls to these methods from destroy(), afterSetStore(), and onStoreLoad().

Verification:

  • Ensure test/playwright/unit/grid/Teleportation.spec.mjs no longer crashes with TypeError.
  • Verify no regressions in component column demos.

Related:

Metadata

Metadata

Assignees

Labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions