-
-
Notifications
You must be signed in to change notification settings - Fork 202
Remove obsolete component management logic from Grid.Body #9018
Copy link
Copy link
Closed
Labels
Description
Objective:
Remove clearComponentColumnMaps and cleanupComponentInstances methods from Neo.grid.Body. These methods are obsolete artifacts from the pre-Row-Pooling architecture and are causing crashes (TypeError: Cannot read properties of undefined (reading 'forEach')) because column.map no longer exists.
Context:
- Old Architecture:
GridBodymanaged component instances (e.g., Sparklines) usingcolumn.map. - New Architecture:
Neo.grid.Rowmanages its own component instances inthis.componentsand cleans them up in itsdestroy()method. - The Bug: Unit tests exposed that
GridBodywas still attempting to accesscolumn.mapduringdestroy()andonStoreLoad(), causing a hard crash.
Changes Required:
- File:
src/grid/Body.mjs - Action: Delete
clearComponentColumnMapsandcleanupComponentInstances. - Action: Remove calls to these methods from
destroy(),afterSetStore(), andonStoreLoad().
Verification:
- Ensure
test/playwright/unit/grid/Teleportation.spec.mjsno longer crashes withTypeError. - Verify no regressions in component column demos.
Related:
- Follow-up to ticket Refactor Grid.Body to extend Component.Base and use internal Row Pool #9017 (Grid Body Refactor).
- Unit Test failure in
Teleportation.spec.mjs.
Reactions are currently unavailable