Change ExecutionContext.Clone to public#318
Merged
shargon merged 5 commits intoneo-project:masterfrom May 15, 2020
Merged
Conversation
|
Is this ready for testing? @shargon |
Member
Author
Yes please |
|
Can you give me an example? what it is used for, or how to use it 🤔 @shargon |
Member
|
I think it is not necessary. See neo-project/neo#1629 (comment). We need to load a new context for the callbacks. |
Member
Author
But then we wont have the shared variables |
Member
|
Callback methods should be stateless. |
|
I have tested it whit neo-project/neo-devpack-dotnet#262.
In addition, an exception is thrown when deploy contract if |
Member
Author
But how can we prevent the use of static variables? |
Member
Author
|
@ProDog could you create this test in dev-pack repository? |
OK |
erikzhang
reviewed
May 15, 2020
erikzhang
previously approved these changes
May 15, 2020
erikzhang
approved these changes
May 15, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


It will be required for neo-project/neo#1629