Skip to content

Check items after copy an array/struct (3x)#204

Merged
shargon merged 6 commits intomasterfrom
shargon-patch-1
Sep 26, 2019
Merged

Check items after copy an array/struct (3x)#204
shargon merged 6 commits intomasterfrom
shargon-patch-1

Conversation

@shargon
Copy link
Copy Markdown
Member

@shargon shargon commented Sep 19, 2019

@shargon shargon requested a review from erikzhang September 19, 2019 14:31
@codecov-io
Copy link
Copy Markdown

codecov-io commented Sep 19, 2019 •
edited
Loading

Codecov Report

Merging #204 into master will decrease coverage by 0.01%.
The diff coverage is 77.77%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #204      +/-   ##
==========================================
- Coverage   79.32%   79.31%   -0.02%     
==========================================
  Files          16       16              
  Lines        1422     1421       -1     
==========================================
- Hits         1128     1127       -1     
  Misses        294      294
Impacted Files Coverage Δ
src/neo-vm/ExecutionEngine.cs 70.75% <77.77%> (-0.05%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6676592...254a7fc. Read the comment docs.

@shargon shargon changed the title Check items after copy an array/struct Check items after copy an array/struct (3x) Sep 19, 2019
erikzhang
erikzhang previously approved these changes Sep 19, 2019
View reviewed changes
@shargon
Update UT
779e369 
Now when the execution fail, the item still in the stack
@shargon
Update UT
35d1add 
Now when the execution fail, the item still in the stack
@shargon
Update NEWARRAY.json
39705ac
@shargon shargon requested a review from erikzhang September 19, 2019 20:45
@erikzhang
Copy link
Copy Markdown
Member

erikzhang commented Sep 20, 2019

@shargon Do you think we should skip checking the stack when FAULT? #206

@shargon
Copy link
Copy Markdown
Member Author

shargon commented Sep 20, 2019

Do you think we should skip checking the stack when FAULT? #206

I think that all the VM should have the same behaviour, and this check can ensure that this happend.

@erikzhang
Copy link
Copy Markdown
Member

erikzhang commented Sep 26, 2019

Conflict

@shargon
Copy link
Copy Markdown
Member Author

shargon commented Sep 26, 2019

Solved

@shargon shargon merged commit ddcabba into master Sep 26, 2019
@shargon shargon deleted the shargon-patch-1 branch September 26, 2019 15:16
@vang1ong7ang vang1ong7ang mentioned this pull request Oct 2, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@erikzhang erikzhang erikzhang approved these changes

+2 more reviewers

@steven1227 steven1227 steven1227 approved these changes

@vang1ong7ang vang1ong7ang vang1ong7ang approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

port-to-2.x

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@shargon @codecov-io @erikzhang @steven1227 @vang1ong7ang