[N3] Unify RPC logic and fix size check#936
Merged
shargon merged 1 commit intoneo-project:master-n3from Dec 2, 2025
Merged
Conversation
Jim8y
approved these changes
Dec 2, 2025
vncoelho
approved these changes
Dec 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The condition tx.Length > 1024 has been removed because it is not present in the transaction validation.
This pull request refactors network fee calculation logic in the
RpcServer.Wallet.csfile to improve code maintainability and reduce duplication. The main change is the extraction of repeated fee calculation code into a new helper method, which is then used in multiple transaction-related methods.Refactoring for maintainability:
EnsureNetworkFeeto encapsulate the network fee calculation and limit enforcement logic, replacing duplicated code in transaction creation methods (SendFrom,SendMany, andSendToAddress).SendFrom,SendMany, andSendToAddressmethods to use the newEnsureNetworkFeehelper, removing inline fee calculation logic and simplifying these methods. [1] [2] [3]