Move SystemLog to neo-cli#587
Merged
shargon merged 22 commits intoneo-project:masterfrom May 26, 2020
Merged
Conversation
…and "log off" commands to neo-cli.
Co-authored-by: Owen Zhang <38493437+superboyiii@users.noreply.github.com>
erikzhang
reviewed
May 15, 2020
shargon
reviewed
May 15, 2020
Conversion utility methods for Neo-cli (neo-project#535)
Contributor
Author
|
Help needed: |
Contributor
|
Waiting for neo-project/neo#1656 |
Tommo-L
reviewed
May 21, 2020
Co-authored-by: Luchuan <luchuan@ngd.neo.org>
shargon
previously approved these changes
May 21, 2020
Member
|
Should we remove the |
Member
|
I think it is good to remove as you suggested and discussed above, @erikzhang. |
Member
|
However, @erikzhang, it is now blocking neo-project/neo-modules#246 (review). |
vncoelho
previously approved these changes
May 21, 2020
shargon
previously approved these changes
May 21, 2020
erikzhang
requested changes
May 22, 2020
erikzhang
approved these changes
May 25, 2020
shargon
approved these changes
May 25, 2020
nicolegys
approved these changes
May 26, 2020
Contributor
nicolegys
left a comment
There was a problem hiding this comment.
Test passed.
Situations:
1."ConsoleOutput": false, "Active": false
2."ConsoleOutput": false, "Active": true
3."ConsoleOutput": true, "Active": true
Folders in Logs_xxx:
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Close #228.