added unconnectedPeers and badPeers to OnShowNodeCommand#5
Conversation
added 6 commits
July 29, 2017 11:54
* MainService.cs: 1. changed prompt from "ant" to "neo". 2 added text to the "help" command to describe block import and export.
line with neo unit tests. * MainService.cs: added unconnected peers and bad peers to "Show node" CLI command
erikzhang
requested changes
Aug 2, 2017
Member
erikzhang
left a comment
There was a problem hiding this comment.
I saw an "import blocks" command in help message, but the command is not in the code. Please remove it.
erikzhang
reviewed
Aug 2, 2017
Member
erikzhang
left a comment
There was a problem hiding this comment.
And why we should include package "NuGet.Build.Tasks.Pack"?
Author
|
NuGet.Build.Tasks.Pack is required on VS2017 on OSX to run "create NuGet Package". i run nuget package before running "dotnet publish -c release" because it gives clearer error messages when packages are linked improperly. |
Member
|
Did you try "dotnet restore"? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
updated to netcoreapp1.1 as the City of Zion unit tests are based on netcoreapp1.1 , so this allows the nuget packages to be used by their neo-cli.
added unconnectedPeers and badPeers to OnShowNodeCommand.
This is useful for debugging the NEO network. For example there was a problem seeing china from chicago, usa on July 31st. I saw the unconnectedPeers node count drop from ~250 to ~70.