Conversation
Fix inconsistency between Plugin name and Plugin class name. For example: ```SimplePolicy``` is using ```SimplePolicyPlugin``` as class name, but using ```SimplePolicy``` as plugin name. This issue also could be seen on ```RpcSystemAssetTracker```. I think it's also necessary to unify plugin class name on neo3 to avoid this issue.
shargon
left a comment
There was a problem hiding this comment.
But the name of the class is used?
Hi, Shargon. What do you mean? Yes the class is used, but uninstall can't be successful if you add this check. I think the best solution is to unify class name to plugin project name. But I'm not sure if it will influence a lot or not. |
|
For reproduce the error, what are the steps?
|
Yes. Now only |
|
Check my last changes, it works for me when is loaded. But the problem is how to remove a used plugin. |
|
mmmm... i see two solutions, as you said.
|
I think solution 1 makes sense for making plugins more regular. |
|
@superboyiii, how is this PR? Should we merge this? |
|
1 is good for me |
|
If we want to remove the plugin name, this should be done in |
|
@superboyiii Can you test it again? |
|
Sure |
|
Here's my test steps and result.
Summary: Test Pass. |
Fix inconsistency between Plugin name and Plugin class name. For example:
SimplePolicyis usingSimplePolicyPluginas class name, but usingSimplePolicyas plugin name. This issue also could be seen onRpcSystemAssetTracker. I think it's also necessary to unify plugin class name on neo3 to avoid this issue.