upgrade to neo 2.0.1 breaks build, missing lib directive.#4
Conversation
added 5 commits
July 29, 2017 11:54
* MainService.cs: 1. changed prompt from "ant" to "neo". 2 added text to the "help" command to describe block import and export.
Member
|
There isn't a command of "import blocks" in the code. |
Author
|
ah, I typoed and didn't catch it i meant to add netcoreapp1.0 The "neo" project doesn't target netcoreapp1.0 https://github.com/neo-project/neo/blob/master/neo/neo.csproj The "neo-cli" project does target netcoreapp1.0 https://github.com/neo-project/neo-cli/blob/master/neo-cli/neo-cli.csproj This causes the neo-cli to fail to build when I do dotnet publish -c release on neo-cli. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
neo 2.0.1 does not have a netstandard1.6 lib on nuget, only a net461 lib, this causes the build to fail claiming an incompatibility between libraries.
The CLI prompt was still "ant"
The CLI allows importing and exporting of blocks, but the help text doesn't say the ability exists.
I apologize if I did something the wrong way, this is my first github pull request.