Skip to content

Deleting import blocks from neo-cli v3.0#228

Merged
erikzhang merged 3 commits intoneo-project:v3.0from
vncoelho:v3.0-MovingImportBlocksToPlugin
Sep 11, 2018
Merged

Deleting import blocks from neo-cli v3.0#228
erikzhang merged 3 commits intoneo-project:v3.0from
vncoelho:v3.0-MovingImportBlocksToPlugin

Conversation

@vncoelho
Copy link
Copy Markdown
Member

@vncoelho vncoelho commented Sep 8, 2018

@erikzhang, I deleted the functions.
I tested here and, apparently, it worked as expected. Thanks for the help and teachings.

image

@erikzhang
Copy link
Copy Markdown
Member

neo-project/neo-modules@fe125f6

I added the functionality of the export block to the plugin.

@vncoelho

@vncoelho
Copy link
Copy Markdown
Member Author

vncoelho commented Sep 10, 2018

Sorry, @erikzhang, the title was wrong (I do not know why I wrote this), it is actually: "Deleting import blocks from neo-cli"
I think that we may need to delete the function and the call around here, right? That how I proceeded for using the plugin.

Now we also need to delete the export...kkkkkkk aheuahueahuea

@vncoelho vncoelho changed the title Moving export blocks to plugin Deleting import blocks from neo-cli v3.0 Sep 10, 2018
@erikzhang
Copy link
Copy Markdown
Member

Now we also need to delete the export...

This is what I want to say.

@erikzhang erikzhang merged commit 3ae4deb into neo-project:v3.0 Sep 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants